Set network credentials - references #1941

fsprojects · Oct 6, 2016 · 1ec71d3 · 1ec71d3
1 parent 9420714
commit 1ec71d3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+#### 3.21.3 - 06.10.2016
+* BUGFIX: Set network credentials - https://github.com/fsprojects/Paket/issues/1941
+
 #### 3.21.2 - 05.10.2016
 * BUGFIX: Swapped parameters of FindVersionsForPackage
 

diff --git a/src/Paket.Core/Utils.fs b/src/Paket.Core/Utils.fs
@@ -492,7 +492,7 @@ let internal addHeader (client:WebClient) (headerKey:string) (headerVal:string)
     client.Headers.Add (headerKey, headerVal)
 #endif
 
-let inline createWebClient (url,auth:Auth option) =
+let createWebClient (url,auth:Auth option) =
 #if USE_HTTP_CLIENT
     let handler =
         new HttpClientHandler(
@@ -536,6 +536,7 @@ let inline createWebClient (url,auth:Auth option) =
         //so use THIS instead to send credentials RIGHT AWAY
         let credentials = Convert.ToBase64String(Encoding.ASCII.GetBytes(username + ":" + password))
         client.Headers.[HttpRequestHeader.Authorization] <- sprintf "Basic %s" credentials
+        client.Credentials <- new NetworkCredential(username,password)
 
     | Some (Token token) ->
         client.Headers.[HttpRequestHeader.Authorization] <- sprintf "token %s" token

diff --git a/src/Paket/Paket.fsproj b/src/Paket/Paket.fsproj
@@ -53,8 +53,8 @@
     <StartWorkingDirectory>D:\code\PaketKopie</StartWorkingDirectory>
     <StartArguments>update -f</StartArguments>
     <StartWorkingDirectory>D:\code\Paket\integrationtests\scenarios\i001117-aws\temp</StartWorkingDirectory>
-    <StartArguments>install</StartArguments>
-    <StartWorkingDirectory>D:\code\Paket\integrationtests\scenarios\i001270-net461\before</StartWorkingDirectory>
+    <StartArguments>update</StartArguments>
+    <StartWorkingDirectory>D:\temp\repo3</StartWorkingDirectory>
   </PropertyGroup>
   <PropertyGroup>
     <MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion>