-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip json comments #1448
Skip json comments #1448
Conversation
Test failure on windows:
|
Hello, After investigation, the failing test is The error message you highlighted about an invalid date is output by the I'm not sure why the
Do you think it would be possible to simply run the build again? |
Yeah, the tests aren't ideal. Ah well! Thanks a bunch, it looks good. |
Thanks a lot! |
Closes #1215
Feel free to discuss!
One thing of note: there is no way to disallow comments in json now.
I didn't feel like it was something the user would usually want, but there might be some edge cases where it could be needed (especially since it's not standard json).
I'm not sure what would be the best way to support this option without littering the parsing methods with a boolean or something like that... (and how to keep backward compat)
Bonus:
.gitattributes
to format new lines the same way.editorconfig
wants them:lf
for almost all file types. (I did this after having multiple problems while working in the code and having mixed CRLF and LF...)(These are the same changes I did in PR Implement "inline schemas": ability to add type hints into the type providers' source documents #1447. I'm thinking that it might be easier to get them accepted in this small PR, so I can remove them from the big one and make it easier to review)