Format all code #1441
Format all code #1441
Conversation
|
Fantomas is |
|
even if there is a reason for sticking to |
|
Right, so I should be able to bump the global json without many consequences right? |
|
Yes, with a caveat - the PR/merge workflows use the - name: Setup dotnet
uses: actions/setup-dotnet@v2
with:
dotnet-version: |
5.0.x
6.0.x |
|
Reformatting may be needed after pull Regarding .NET version - we can update it - it might require an update to paket and fake? |
| maxNumberOfRows | ||
| = | ||
|
|
||
| using (logTime "LoadingTextToBeParsed" valueToBeParsedOrItsUri) |
There was a problem hiding this comment.
I will pre-change all explicit using to use _holder = ... to prevent this indentation happening. Then we reformat
|
Updating to net6 is possible, it will just be annoying. IIRC this requires FAKE to move to be project-based |
| typeof<int> | ||
| typeof<int64> ] | ||
| typeof<float>, | ||
| [ typeof<Bit0> |
There was a problem hiding this comment.
Please allow maximum list size large enough to allow these to be formatted single line
src/Csv/CsvGenerator.fs
Outdated
| let ctor = | ||
| ProvidedConstructor( | ||
| [ for field in fields -> field.ProvidedParameter ], | ||
| invokeCode = |
There was a problem hiding this comment.
These invokeCode expand out a fair bit, I will pre-adjust them to be inner function bindings
src/Xml/XmlRuntime.fs
Outdated
| text, | ||
| LoadOptions.PreserveWhitespace | ||
| ) | ||
| .Root |
There was a problem hiding this comment.
This is strangely expanded. Is line width 80? I think it could be set to 120.
|
@nojaf I'll do the merge and the things I mentioned above, and re-format |
|
OK this is now ready - I'm happy with the code after formatting, more or less |
|
I'll make a couple more tweaks to .edtiorconfig in a separate PR |
|
@nojaf Thank you sooooooo much for pushing this along. It makes the repository so much easier to maintain and contribute to |
|
You are most welcome. The more projects are formatted, the more exposure for Fantomas 😸. |
Hello, would you be interested in using Fantomas for this community project?