Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign assemblies with strong name key file #1386

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Sign assemblies with strong name key file #1386

merged 1 commit into from
Jul 27, 2021

Conversation

JosephFerano
Copy link
Contributor

This PR addresses #990 and #1235

@JosephFerano
Copy link
Contributor Author

I attempted to use public signing, but ran into a similar issue to this:

dotnet/machinelearning#600 (comment)

If you would prefer having the snk file somewhere else, let me know and I'll gladly move it to it's appropriate location.

@dsyme
Copy link
Contributor

dsyme commented Jul 27, 2021

See comment here, #1235 (comment)

@dsyme dsyme merged commit 37aa471 into fsprojects:main Jul 27, 2021
@JosephFerano
Copy link
Contributor Author

Thank you for merging. The reason for the strong naming is that our .netstandard project was recently integrated into one of our products. It's a plugin for an older system that only supports .Net framework and assemblies have to be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants