Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set sourcelink to be a private asset so that it doesn't get added to package dependencies #1377

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

baronfel
Copy link
Contributor

Fixes #1376 to remove the errant sourcelink dependency.

After this change, the nuspec contains the following dependency groups:

<dependencies>
  <group targetFramework=".NETStandard2.0">
    <dependency id="FSharp.Core" version="4.7.2" exclude="Build,Analyzers" />
  </group>
</dependencies>

@baronfel
Copy link
Contributor Author

Test errors are from the worldbank data, but don't represent a problem with the package.

@cartermp cartermp closed this Apr 27, 2021
@cartermp cartermp reopened this Apr 27, 2021
Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baronfel

@cartermp cartermp merged commit bad0e36 into fsprojects:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about new dependencies in 4.1.0
2 participants