Modified escaping of query string parameters #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified unit failing unit test Added new unit test
sever returns 404
|
Thanks! This looks like exactly the fix we need. @cartermp @ovatsus @tpetricek @colinbull If you get a moment could you review? |
|
EscapeDataString has problems with large payloads, that's why we changed it, see #1112 |
|
Ah, nevermind, that was for the body, which you are not changing |
ovatsus
reviewed
Jun 2, 2020
| @@ -33,7 +33,6 @@ Xml,TypeInference.xml,false,false,,false, | |||
| Xml,SampleAzureServiceManagement.xml,false,false,,true, | |||
| Xml,TimeSpans.xml,false,false,,true, | |||
| Xml,,false,false,,false,po.xsd | |||
| Xml,,false,false,,false,http://europa.eu/rapid/conf/RSS20.xsd | |||
There was a problem hiding this comment.
I removed it as RSS20.xsd does not exist at url anymore and was causing unit tests to fail.
I could not find an updated url.
Appologies I should have updated the PR comment.
There was a problem hiding this comment.
That URL is now retuning a failure, I think it can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1263
Escape query strings using
Uri.EscapeDataStringinstead ofUri.EscapeUriString, this should correctly escape all URI reserve characters so they can be used as literals in query strings.