Expose InnerResponse, Http properties #1291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
FSharp.Data.WebResponse
wrapper does not easily allow the user to access the original response.In particular, the
WebResponse
will normally (always?) be aHttpWebResponse
, which exposes critical properties likeStatusCode
, which are currently buried pretty deep under type tests (and I might not have found them at all without debugging and looking at the source):This PR adds to
FSharp.Data.WebResponse:
a set of properties that wrap those in HttpWebResponse, returning
None
if the wrapped response isn't aHttpWebResponse
an
InnerResponse
property that exposes the originalWebResponse
, for anything else a user might need