#1212 CssSelect fails when there is no html tag #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1212
When calling
CssSelecton anHtmlDocument, it first selects the html tag and applies the selector to that to find matching descendants. But if theHtmlDocumentdoesn't have an html tag this fails and according to the HTML Specificaton this is valid.I changed the implementation of
CssSelect(doc:HtmlDocument, selector)fromdoc.Html()todoc.Elements()in order to apply the selector to all the root tags of the document. If the root tag is html, then it will work as before, but now it will also work if you have a page that omits it and therefore has multiple root tags, like for example:Please let me know if there are any issues with this fix or if there is anything I can improve.