Fix of the choose pull request. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain so as to allow the call to OnNext to be in tail position. This is one of the rare cases where due a return being used in the catch branch, it is not actually possible to get the same efficiency in F# as it would be in C#. It is good that `choose` uses options intrinsically.
mrakgr
changed the title
|
The right way to implement all of this is subtle. Glad I spotted this. |
panesofglass
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the implementation of choose again so as to allow the call to OnNext to be in tail position.
This is one of the rare cases where due a return being used in the catch branch, it is not actually possible to get the same efficiency in F# as it would be in C#. It is good that
chooseuses options intrinsically so it should be close to optimal.