Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #129 - fromEventHandler #130

Merged

Conversation

danien
Copy link
Contributor

@danien danien commented Feb 6, 2020

Explicitly specify 'EventArgs type parameters for Observable.fromEventHandler to ensure it returns IObservable<'EventArgs> instead of IObservable. Closes Issue #129

Explicitly specify 'EventArgs type parameters for Observable.fromEventHandler to ensure it returns IObservable<'EventArgs> instead of IObservable<object>. See Issue fsprojects#129
@danien
Copy link
Contributor Author

danien commented Feb 6, 2020

I'm not sure why the CI command-line build is failing with the following error:

System.IO.FileLoadException: Could not load file or assembly 'System.Threading, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly 
reference. (Exception from HRESULT: 0x80131040)
   at System.Console.get_OutputEncoding()
   at Program.main(String[] args) in D:\a\1\s\src\app\Fake.netcore\Program.fs:line 306

It happens locally as well if I try to build using fake.cmd on Windows and fake.sh on macOS Mojave, but I can build both FSharp.Control.Reactive and FSharp.Control.Reactive.Testing projects just fine and all tests pass in Visual Studio 16.4.3.

@panesofglass panesofglass merged commit 7287e22 into fsprojects:master Feb 7, 2020
@panesofglass
Copy link
Collaborator

Thanks! I have to get the build fixed to publish, but will try to do so soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants