Sync with canonical Async.AwaitTaskCorrect #49
Conversation
|
NOTE there are two behavior changes here:
Ran this past @eiriktsarpalis; he confirmed there is no useful variation in the impl herein ASIDE: Having a immediate release for this is not critical for me as I'm comfortable there is no consequential behavior change that I need - hopefully I'll get around to doing cleanup on |
bartelink
force-pushed
the
sync-await-task-correct
branch
from
4c52d74 to
1513b51
Compare
bartelink
force-pushed
the
sync-await-task-correct
branch
from
1513b51 to
1390edf
Compare
| static member AwaitTaskCorrect(task : Task<'T>) : Async<'T> = | ||
| Async.FromContinuations(fun (sc,ec,cc) -> | ||
| task.ContinueWith(fun (t : Task<'T>) -> | ||
| if task.IsFaulted then ec t.InnerException |
There was a problem hiding this comment.
when I glanced at this in analyzing what became dotnet/fsharp#13165, I went down a rathole of what would happen if this threw and/or returned null, and what that might lead to within Async.FromContinuations. For this reason I feel it's best to have this inlined and straightforward (along with the other benefits of it being identical to the canonical version)
| if e.InnerExceptions.Count = 1 then ec e.InnerExceptions[0] | ||
| else ec e | ||
| elif task.IsCanceled then | ||
| ec (TaskCanceledException()) |
There was a problem hiding this comment.
note intentional swapping to ec instead of cc, and a different exception
In isolating dotnet/fsharp#13165, the fact that the
AwaitTaskCorrectimpl herein predates the current fsssnip edition, and that thetask.InnerExceptionis subtle led me down additional paths that would be nice to avoid, especially given that ultimately there should be convergence in the implementations via fsharp/fslang-suggestions#840.