Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the global.json parsing in Fake.Dotnet.Cli to use System.Text.Json instead of Newtonsoft.Json #2839

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Oct 6, 2024

Description

refs comments in #2825 about using System.Text.Json rather than Newtonsoft.Json

TODO

  • The .NET 6.0(+) builds can use the inbox version of System.Text.Json, but the .NET Standard 2.0 build needs the NuGet package. As it stands, the package reference is transitive rather than direct.
  • The code aorund here is called indirectly by the unit tests for Fake.Dotnet.Cli but I don't think there is anything direct for the global.json parsing (maybe there could be, to test things like json comment handling or issues like [REGRESSION] FAKE 6.1.0 fails with dotnet preview versions #2803)

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Test Results

    9 files  ±0      9 suites  ±0   25m 39s ⏱️ - 27m 25s
  439 tests ±0    439 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 251 runs  ±0  1 251 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 00e887e. ± Comparison against base commit 10f0b21.

♻️ This comment has been updated with latest results.

@Numpsy Numpsy marked this pull request as ready for review November 12, 2024 09:44
@xperiandri xperiandri changed the title Change the global.json parsing in Fake.Dotnet.Cli to use System.Text.… Change the global.json parsing in Fake.Dotnet.Cli to use System.Text.Json instead of Newtonsoft.Json Nov 12, 2024
@xperiandri xperiandri merged commit 227e5d4 into fsprojects:master Nov 12, 2024
5 checks passed
@Numpsy Numpsy deleted the dotnet_cli_stj branch November 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants