-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.20.0 #2466
Merged
Merged
Release 5.20.0 #2466
Changes from all commits
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
70d1790
added SignTool for v5
jhromadik b7a12d6
added 2 ways of calling the functions - one taking a set-options func…
jhromadik c2d14a5
Merge branch 'release/next' into signtool-for-v5
jhromadik 63f41cf
Fix an AppVeyor environment variable being null because it does not e…
teo-tsirpanis bae6c1a
removed record-style functions, made signing certificate a required p…
jhromadik 81a1d4f
random string generation in tests
jhromadik 0132a79
minor tweaks
jhromadik edd47ac
added SignCertificate.FromFile and SignCertificate.FromStore static h…
jhromadik 9492ac6
TimeStampOptions - pulled ServerUrl and Algorithm to top level; Serve…
jhromadik 2b4e9f2
added function signWithTimeStamp
jhromadik 7671b13
no Timeout means no timeout
jhromadik ebd54b7
"inlined" ToolOptions
jhromadik 0bde1b4
release notes
matthid 64a3585
Forgot to remove a file from dotnet-fake.
teo-tsirpanis 1ae7c3d
Use the correct SPDX license expression.
teo-tsirpanis 437f7fa
Merge pull request #2467 from teo-tsirpanis/dotnet-fake-assemblyinfo
matthid 0fefbc7
Merge pull request #2468 from teo-tsirpanis/patch-2
matthid 06d7d9d
adds test to reproduce error
ids-pfinn 55c3561
fixes bug and adds tests
ids-pfinn cb5cfba
using Arguments API to prepare arguments for the tool
jhromadik ab65170
improved tests to make sure the final arguments contain exactly what …
jhromadik 2e75509
renames test to follow naming pattern
ids-pfinn 6d479f6
fixes a unit test that I missed
ids-pfinn 32620c3
using signtool default SHA1 for digest algorithm
jhromadik 3072942
tidying up
jhromadik 9757dc8
Fix typo of references-files argument
nilshelmig 2132739
It's references-file not references-files
nilshelmig 830fefc
update FCS dependency to latest to get around new optional parameters
baronfel 7b85fab
add type annotations to deal with overloads that are avaialable one n…
baronfel f9888d5
fixing automatic signtool.exe lookup
jhromadik ca01c1b
fix overloads to use strings
baronfel 0cff0d1
use new collapsible trace format for the gitlab trace writer
baronfel bb50ae8
Merge branch 'patch-1' of https://github.com/nilshelmig/FAKE into rel…
matthid 41d9f44
Merge branch 'update-FCS' of https://github.com/baronfel/FAKE into re…
matthid 10cd9bd
Merge branch 'signtool-for-v5' of https://github.com/jhromadik/FAKE i…
matthid 9937ac5
Merge branch 'gitlab-collapsible-trace-reporter' of https://github.co…
matthid bdce174
release notes
matthid f5b6cc0
cleanup output for gitlab writer
baronfel c49011a
update FCS 34.1.1 across all paket groups
baronfel c77d659
changelog: recreate unreleased section after promote
280000c
add changelog format sample
763acda
add dummy paket dependency manager implementation, need to hook it up…
baronfel e795ad0
dependency manager must take a string option for the output directory
baronfel 6e141a8
add reference to dependency manager all the time
baronfel 2fa69b2
must supply langversion preview to use dependency management
baronfel c02a388
handle empty locations (ie when library is ILMerged)
baronfel f648878
Merge branch 'gitlab-reporter-tweaks' of https://github.com/baronfel/…
matthid 5e4f4ea
release notes
matthid a3560c5
make sure to add both dependencymanager compileroptions wherever they…
baronfel 3caa1bd
add nowarn that seems to be necessary now too
baronfel d7748ef
don't pass in a potentially-bad empty string argument to the compiler
baronfel b2f141f
fix typo
baronfel d58b8b9
test and fix the gitlab reporter
baronfel 6a4902e
Merge pull request #2480 from vilinski/bugfix/changelog-unreleased
matthid 8033181
Ignore warning, workaround https://github.com/dotnet/fsharp/issues/8678
matthid ce5e9b9
Merge branch 'unify-compiler-options-for-scripts' of https://github.c…
matthid 9f01307
Filter warning later instead of before (workaround https://github.com…
matthid 70136ca
release notes
matthid fd2c3ee
Merge branch 'gitlab-reporter-fixed-for-real-hopefully' of https://gi…
matthid 58dfa4b
mark stuff internal
matthid e5fe2a3
revert changes to gitlab runner to restore old, ansi-color behavior
baronfel 096f045
remove release notes about collapsible gitlab reporter, since we are …
baronfel 333e137
Merge pull request #2485 from baronfel/revert-gitlab-ci-runner-trace
matthid c6fd14f
Support running from .net core tool-manifest tool
jeremyabbott b8b422c
Updates documentation
jeremyabbott d102ef3
typo
milbrandt 6ed5e04
Merge pull request #2492 from milbrandt/bugfix/typo
matthid 09e40b6
fix tests
matthid 2949461
fix another url
matthid 86609e5
Remove unnecessary NuGet package references.
teo-tsirpanis 6907e6b
Target only .NET Standard 2.0 in the NetcoreBuild group.
teo-tsirpanis 2069829
Fix the CI build by adding references to System.Net.HttpClient in mor…
teo-tsirpanis d331f39
fix typo
jzabroski 98d321f
Merge pull request #2497 from jzabroski/patch-1
matthid ff51ba8
Merge pull request #2448 from teo-tsirpanis/appveyor
matthid 45c4a2f
Merge pull request #2493 from teo-tsirpanis/release/next
matthid dac1718
update to fcs35 across main, netcore, and netcorerunner projects
baronfel f04a9a1
Merge pull request #2500 from baronfel/update-fcs-35
matthid ad38d03
release notes
matthid 5b18bdf
Fix a wrong decoration
objectx 026052a
Uses Fake.DotNet.ToolType
jeremyabbott e052906
Updates documentation to reflect ToolType
jeremyabbott 8ab8e89
Fix docs according to twitter feedback
matthid 8f6030e
Merge pull request #2489 from jeremyabbott/octo-tool-manifest
matthid a6120ff
Merge pull request #2502 from objectx/patch-1
matthid ae35979
Fix typo
matthid d5880fa
Refactor to use timeout per Octokit API
csmager 8e3841d
Use default credentials for proxy when connecting to GitHub API
csmager 6592c84
Add `IncludeSymbols` to `PackOptions`
devployment f07cf12
Merge pull request #2507 from csmager/github-proxy
matthid ab9cea7
fix appveyor
matthid 58914aa
Merge pull request #2508 from devployment/fix_2506
matthid 97eff12
update packages and update Fake.DotNet.FSFormatting
matthid 7157a0b
Merge branch 'release/next' of github.com:fsharp/FAKE into release/next
matthid 2f8b467
add cli reference
matthid beea2f3
update fsf
matthid 355544f
update restore targets
matthid b596a7e
Update Paket.Core
matthid 27b3dff
update paket.core
matthid 5e64406
make stable release
matthid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"sdk" : { | ||
"version": "3.1.100" | ||
"version": "3.1.201" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Remainder) Maybe this should be named
Fake.Runtime.PaketDependencyManager
instead.But as we have discussed this is probably temporary (and this is basically implementation detail, so we probably can change that anytime)
/cc @baronfel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
along with this, the dependencymanager build has warnings that get logged that caused FSAC to throw errors initially (because FSAC has WarningsAsErrors turned on).
these are...fairly interesting, because they related to the pickled metadata nodes. I don't know which nodes in question are failing though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, it seems like
release/next
is now red as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is still some underlying issue here. I have no idea what the problem is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baronfel is there some naming scheme we need to follow for FCS/F# Compiler to find the dependency-manager? I guess my suggestion doesn't follow that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added a comment to the fsproj for the dependency manager with the pattern the compiler looks for. It looks for DependencyManager.dll for candidates.