Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing github release for 6.1.0 #2800

Closed
NogginBops opened this issue Aug 6, 2024 · 25 comments
Closed

Missing github release for 6.1.0 #2800

NogginBops opened this issue Aug 6, 2024 · 25 comments

Comments

@NogginBops
Copy link

Description

The 6.1.0 nuget package has been released without a matching GitHub release tag.

This should probably be fixed, and even if the 6.1.0 nuget package is accidental a matching tag should probably be established anyway.

@xperiandri
Copy link
Collaborator

@NogginBops I know
Pipeline crashes so it had not completed altogether.
I thought ignore_push

FAKE/build.fsx

Line 480 in b585605

not ignore_conflict
is --skip-duplicate in dotnet nuget push
But it did not work the same.

So now I have 2 release pipelines crashed:

  1. Pushed NuGet but stop on docs publishing
  2. Did not skip pushing a duplicate

If you can help I'll appreciate

@xperiandri
Copy link
Collaborator

The other question is will the first release pipeline pick up the changes pushed to main if rerun?

@NogginBops
Copy link
Author

I'm not very familiar with the github actions setup in this repo, my guess is that the best course of action is probably to manually add the GitHub release to match the nuget release. Then fixing/understanding the action and the failure can be understood and a new potentially fixed nuget package can be released (and the old nuget package can be unlisted or deprecated if necessary.)

I could potentially look into the GitHub actions tomorrow and see if I can make sense of anything enough to be helpful.

@xperiandri
Copy link
Collaborator

No new package needs to be release. Just fix skipping pushing the same version of the package

@xperiandri
Copy link
Collaborator

So we fixed skipping NuGet now we have issue with authectication to publish docs.
@NogginBops can you help?
https://github.com/fsprojects/FAKE/actions/runs/10377079510/job/28730466949#step:10:576

@Numpsy
Copy link
Contributor

Numpsy commented Aug 20, 2024

Is it worth trying to publish the docs with a specific github action rather than doing it manually in the fsx script?
e.g. https://github.com/fsprojects/fantomas/blob/a4788cbdf856ae6f47b6032f7cb8ecb506ad7733/.github/workflows/main.yml#L39

@xperiandri
Copy link
Collaborator

I would prefer fixing the pipeline

@Numpsy
Copy link
Contributor

Numpsy commented Aug 21, 2024

Ok, the github pages part has worked now, but it's failed at the next step with

Something failed, trying again: System.MissingMethodException: Method not found: 'Int32 Octokit.Release.get_Id()'.
   at [email protected](Release release)
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, b result1, FSharpFunc`2 userCode) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 528
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112

instead :-(

@Numpsy
Copy link
Contributor

Numpsy commented Aug 21, 2024

Not sure if this is it, but it looks like the Release.Id property was changed from an int to a long in octokit/octokit.net#2941

@xperiandri
Copy link
Collaborator

Approved PR, waiting for build to complete

@Numpsy
Copy link
Contributor

Numpsy commented Aug 21, 2024

And now it seems to have failed because the previous run successfully pushed a build to Chocolately, and you can't do that twice for the same version :-(

@xperiandri
Copy link
Collaborator

Skip needed again 😄

@Numpsy
Copy link
Contributor

Numpsy commented Aug 22, 2024

I don't an 'ignore duplicates' type option in the choco push docs at https://docs.chocolatey.org/en-us/create/commands/push/ (I've never pushed anything into chocolately myself)

@xperiandri
Copy link
Collaborator

For NuGet it just wraps code in try-with. And if skip flag, then ignore exception

@xperiandri
Copy link
Collaborator

I hope it is the last piece to fix release pipeline

@Numpsy
Copy link
Contributor

Numpsy commented Aug 25, 2024

I can try something like Numpsy@07ac987 which might avoid the immediate failure, but the choco docs only list processes exit codes of 0/1 so I don't know how to determine if the error was a conflict or not other than trying to look at the An error has occurred. This package version already exists on the repository and cannot be modified. console output (which I don't think is directly available at this point in the script

xperiandri pushed a commit that referenced this issue Aug 28, 2024
… is `true` (#2809)

refs #2800 (comment) and following comments.

This was an attempt at getting the release build to work by ignoring the 'version already exists' error that it's getting when trying to push a build to Chocolately with a version number that already exists.
The issue is that it doesn't seem to have much context about what caused the error, so just ignoring all errors would ignore failures for other reasons as well.
@Numpsy
Copy link
Contributor

Numpsy commented Aug 28, 2024

I hope it is the last piece to fix release pipeline

Looks like the latest attempt has failed because it tried to create a 6.1.0 git tag, and one already exists :-(

@xperiandri
Copy link
Collaborator

Something new now

@Numpsy
Copy link
Contributor

Numpsy commented Aug 29, 2024

Hmm, that's back to what #2808 was intended to fix (The release id is a long instead of Int32 now, and something seems to be getting confused somewhere)

@Numpsy
Copy link
Contributor

Numpsy commented Aug 29, 2024

Could it be that build.fsx is downloading the latest version of Octokit (13), and calling it via the old release of Fake.Api.GitHub rather than the version currently being built (and then the mismatch upsets things)?

@Numpsy
Copy link
Contributor

Numpsy commented Aug 29, 2024

Hurrah, finally a successful release build, and the 6.1.0 release is listed now

@xperiandri
Copy link
Collaborator

Yahoo! 🎉🎉🎉
@Numpsy @Thorium do you want 6.1.1 release with what's already merged?

@Thorium
Copy link
Member

Thorium commented Aug 31, 2024

I would prefer 6.1.1 asap because it would unblock some net8 migration issues. I don't really care "should we include one more PR or not", as the currently merged PRs already solve the issues (as I tested merged version directly locally).

@Numpsy
Copy link
Contributor

Numpsy commented Aug 31, 2024

Might be useful to do a quick release to fix #2803 if people are trying to use it with the .NET 9 previews and that helps to get that tested

@xperiandri
Copy link
Collaborator

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants