-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add netcore using .NET CLI #47
[WIP] Add netcore using .NET CLI #47
Conversation
c475691
to
8da00cf
Compare
the Or someones has ideas? /cc @dsyme @KevinRansom |
Hi Enrico, The BinaryFormatter namespace declaration is indeed a leftover from a feature that has long been removed. You can safely remove it. Regarding AppSettings, I think it would be best if all the relevant API was cleared off for CLR builds, as opposed to raising NotSupportedExceptions in the midst of execution. |
ok about binaryformatter, one #ifdef less 😄 i'll ifdef the whole appsettings api out instead of throw. I was asking because maybe you had a replacement in mind, but remove it it's safer atm the overload bug is something i dont know how to workaround, if noone find an idea we need to wait the fix of fsc |
closed in favor of #57 |
There are three issues:
BinaryFormatters
not supported by netcore afaik (it's used? or only the open namespace?)Configuration
for appsettings, not supported by netcore afaik (maybe use Microsoft.Framework.Configuration package?Only the bug with overload stop the build, i made the appsettings fail with not supported exception atm
I'll add appveyor build soon
But having .net cli installed (only windows works atm, there is a bug), from repo root
dotnet restore
cd src/Argu
dotnet build
there is a temporary smoke test prject in
src/Argu.Dotnetcli.Tests
(it can be removed or moved after)cd src/Argu.Dotnetcli.Tests
dotnet build --framework net46
to check net46 works./bin/Debug/net46/win7-x64/Argu.Dotnetcli.Tests.exe
to run itwhen
dnxcore
workscd src/Argu.Dotnetcli.Tests
dotnet run --framework dnxcore50
When everything is green, the built assembly can be added to current
Argu
nuget package for netcore framework