Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.1.2 #192

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Release 6.1.2 #192

merged 6 commits into from
Dec 12, 2023

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Dec 12, 2023

This is an attempt to perform a release via a manual dispatch action.
I'd like to start with just being able to run the release, we can improve some stuff in the future afterwards.

resolves #166
fixes #116
fixes #159

@nojaf nojaf requested a review from bartelink December 12, 2023 11:26
@bartelink
Copy link
Member

bartelink commented Dec 12, 2023

FYI I turned off merge commits just now (as well as wikis and projects) as https://github.com/fsprojects/Argu/commits/master/ seems unnecessarily messy (IME you either need to police commits and go around requesting rebasing, or just stick to squash merges). Open to debate though.

Copy link
Member

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM would like to see 174 at some point but that that should be grounds for a feature bump and 187 can join it I guess?

@bartelink bartelink changed the title Release Release 6.1.2 Dec 12, 2023
@bartelink
Copy link
Member

bartelink commented Dec 12, 2023

Hm seeing lots of build work, (#160 and Got confused; I refer to the PRs that fixed things in the release notes rather than the issues) #127 on master since the last release, so maybe 6.1.2 is not appropriate?

If this was me, I'd be tempted to merge my two PRs and mint a 7.0.0-rc.1, then turn it RC after we prove it's correct wrt jumping to source and the deterministic build flags at https://nuget.info/packages/Argu etc

It'd be good to have the release number in the title of these PRs too (personally in general I tend to use MinVer and put tags on commits, but then I don't have the FAKE skills to do it the hard way!)

@nojaf
Copy link
Collaborator Author

nojaf commented Dec 12, 2023

Hmm, yeah I'm on the fence for this one.
I might just want to try this first and then go for the 6.2.0-alpha-001 with #174 and #187.
I don't think we are really breaking anything in those PRs? I could be wrong, so please point it out if those do contain breaking changes.

@nojaf nojaf merged commit c1bcbf5 into fsprojects:master Dec 12, 2023
4 checks passed
@bartelink
Copy link
Member

Agree probably not breaking anything (was avoiding thinking about it!)
and 7.0 is trumpeting things to an unwarranted degree
note re 6.2.0-alpha-001, better to make that 6.2.0-alpha.1 - dotted parts mean no zero prefixing required in recent semvers AFAIK. (And it's a -beta or -rc to my mind!)

bartelink pushed a commit to bartelink/Argu that referenced this pull request Feb 19, 2024
* Add 6.1.2 to release notes.

* Add dependabot yml

* Add release job.

* Add NuGet key

* Add permissions

* Add 116 entry.
bartelink pushed a commit to bartelink/Argu that referenced this pull request Feb 28, 2024
* Add 6.1.2 to release notes.

* Add dependabot yml

* Add release job.

* Add NuGet key

* Add permissions

* Add 116 entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants