Fallback to TMPDIR if XDG_RUNTIME_DIR is not set #842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most macOS setups,
XDG_RUNTIME_DIR
won't exist, but rather than creating something in the home directory, we can fall back toTMPDIR
. Then, users won't have to find ways to setXDG_RUNTIME_DIR
manually if they want to keep their home directory clean. Setting it manually can have some undesirable consequences, as outlined in the issue.This approach is intended to keep the existing behaviour for users who have
XDG_RUNTIME_DIR
set. If they don't, and haveTMPDIR
set, then theirruntimeDir
will change. Otherwise, it will do nothing for them.There may be users with neither
XDG_RUNTIME_DIR
norTMPDIR
set. I think we will be happy for them to make another PR if they don't want theruntimeDir
in their home directory.Fixes: #833