Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom metadata missing in Public and Signed URLs #1019 #1020

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Custom metadata missing in Public and Signed URLs #1019 #1020

merged 2 commits into from
Dec 28, 2022

Conversation

uddhav
Copy link
Contributor

@uddhav uddhav commented Dec 25, 2022

Fixes #1019

NB: I am not a golang dev - feel free to suggest a proper alternative to resolve #1019.

@uddhav uddhav marked this pull request as ready for review December 25, 2022 16:49
fsouza
fsouza approved these changes Dec 28, 2022
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

fakestorage/object.go Outdated Show resolved Hide resolved
@fsouza fsouza merged commit a72af60 into fsouza:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom metadata missing in Public and Signed URLs
2 participants
@uddhav @fsouza