Do not escape the object name in the fs backend #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
force-pushed
the
fs/do-not-escape-object-name
branch
2 times, most recently
from
2e2c612 to
07dc6ed
Compare
Now fake-gcs-server implicitly creates parent directories when creating an object /foo/bar/baz. This allows creating paths longer than NAME_MAX (256) and interoperating with existing filesystems. This approach does not allow some kinds of objects to exist, e.g., /foo/ with a non-zero object size, although these should be rare.
gaul
force-pushed
the
fs/do-not-escape-object-name
branch
from
07dc6ed to
a0e528e
Compare
|
Sorry had some trouble with Windows. |
fsouza
reviewed
Dec 28, 2022
fsouza
approved these changes
Dec 28, 2022
robklg
added a commit
to bolcom/libunftp
that referenced
this pull request
Dec 16, 2024
This PR re-enables the GCS tests. By pinning to an older version of the fsouza/fake-gcs-server, which [stopped supporting](fsouza/fake-gcs-server#1017) files ending with / in [v1.43.0](https://github.com/fsouza/fake-gcs-server/releases/tag/v1.43.0) We should replace this docker-dependent setup with something more robust. Also reintroducing root_dir setting, which serves as a regression test for #508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now fake-gcs-server implicitly creates parent directories when creating an object
/foo/bar/baz. This allows creating paths longer thanNAME_MAX(256) and interoperating with existing filesystems. This approach does not allow some kinds of objects to exist, e.g.,/foo/with a non-zero object size, although these should be rare.