Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial #260

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Fix tutorial #260

merged 3 commits into from
Aug 10, 2022

Conversation

AndrewIOM
Copy link
Collaborator

Proposed Changes

The tutorial page currently doesn't work (Yahoo stocks has long gone). Replaces with a different API.

Types of changes

What types of changes does your code introduce to RProvider?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@AndrewIOM AndrewIOM merged commit 326ae70 into fslaborg:master Aug 10, 2022
@AndrewIOM AndrewIOM deleted the acm-patch-2 branch August 10, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant