Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const Option<Duration/TimeDelta> unwrap when stable #75

Closed
fsktom opened this issue Mar 27, 2024 · 3 comments
Closed

Const Option<Duration/TimeDelta> unwrap when stable #75

fsktom opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
dependency Waiting for a change in a dependency

Comments

@fsktom
Copy link
Owner

fsktom commented Mar 27, 2024

rust-lang/rust#67441

let one_day: Duration = Duration::try_days(1).unwrap();

change it to

const ONE_DAY: Duration = Duration::try_days(1).unwrap();

when it becomes stable to do so

@fsktom fsktom added the dependency Waiting for a change in a dependency label Mar 27, 2024
@fsktom fsktom self-assigned this Mar 27, 2024
@fsktom fsktom changed the title Const Duration/TimeDelta unwrap when stable Const Option<Duration/TimeDelta> unwrap when stable Mar 27, 2024
@fsktom
Copy link
Owner Author

fsktom commented Mar 27, 2024

#76 or rather TimeDelta instead of Duration heh

@fsktom
Copy link
Owner Author

fsktom commented Sep 8, 2024

Done in ad12c3c

@fsktom fsktom closed this as completed Sep 8, 2024
@fsktom fsktom reopened this Sep 8, 2024
fsktom added a commit that referenced this issue Sep 8, 2024
@fsktom
Copy link
Owner Author

fsktom commented Sep 8, 2024

Actually done in a2301a6 ...

@fsktom fsktom closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Waiting for a change in a dependency
Projects
None yet
Development

No branches or pull requests

1 participant