New icons + ESLint + Visual Studio Code config file #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config file was downloaded from here: https://github.com/ipfs/eslint-config-aegir
Replaced the gateway icons with the IPFS-recommended vector-based icons. https://github.com/ipfs-shipyard/ipfs-css (https://ipfs.io/ipfs/QmVrEsy8JjQAugWm48XvFopi9mEKgxcTXdFmEZ6VR2q6rx/)
|
I can see that IPLD Explorer uses virtualized React tables. If I understand it correctly, if we wanted to move into that direction, we would need to replace our current method for table generation, because the list of gateways should be represented as React list items and not HTML rows. Is this assumption correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the icons with the IPFS-GUI recommended ones.
Installed the IPFS ESLint configuration file.
And created a Visual Studio Code configuration file to start up Chrome and open the project's URL.