Pass pending_vote to Follower::new as an argument explicitly
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnya
commented
Apr 26, 2019
| @@ -309,8 +313,7 @@ where | |||
| if m.log_tail.is_newer_or_equal_than(self.history.tail()) { | |||
| // 送信者(候補者)のログは十分に新しいので、その人を支持する | |||
| let candidate = m.header.sender.clone(); | |||
| self.unread_message = Some(Message::RequestVoteCall(m)); | |||
There was a problem hiding this comment.
FollowerInit に受け渡すために利用されていたようですが、明示的に処理待ちの RequestVoteCall を Follower に渡すようにしたため不要になっているはずです。
There was a problem hiding this comment.
raftlog/src/node_state/follower/init.rs
Line 33 in 66bfca3
unread_message が効いてくるのはここ。
yoffy
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29 を修正する PR です。詳細は issue を確認してください。