Runnable as npm module. #29
Closed
+210
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ | |||
| {{> css}} | |||
| {{> scripts}} | |||
| {{> head}} | |||
| <meta charset="UTF-8"> | |||
There was a problem hiding this comment.
Without this, special characters are not preserved in my test case.
There was a problem hiding this comment.
I had the same issue. I saw it in FontAwesome rendering strange characters instead of Unicode.
|
Sorry for not responding earlier. I found this PR just now. Its hard for me to see whats the differences as you renamed files asfaik. |
|
Closing in favor of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make this code also work as node module instead of CLI only. I can't verify if all intended behaviour is preserved, because tests are missing. But it work well in my project at least :)
Maybe some improvements are necessary, but it looks promising.
I used it in the project
meteor-electronto automatically package meteor desktop applications. See pull request electron-webapps/meteor-electron#86