Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added flake.nix #107

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat: added flake.nix #107

merged 3 commits into from
Nov 18, 2024

Conversation

Maix0
Copy link
Contributor

@Maix0 Maix0 commented Nov 17, 2024

This MR adds an flake.nix into the repository so it can be used with nix.

currently the flake.nix does patch a supposed bug I encountered, but this does remove some function (the ones in stdio.h).

the version is hardcoded, so it is something to change if ever there is a new release. (though the code is updated)
there is a small update to fetch the library path, where if the macro ABSOLUTE_LIBRARY_PATH is defined it will return that directly instead of trying to use a relative path

@froz42
Copy link
Owner

froz42 commented Nov 17, 2024

Thank for your contribution, could you add a mention in the readme ? please

@Maix0
Copy link
Contributor Author

Maix0 commented Nov 18, 2024

The README should have been updated to have a small reference to the nix flake with a command that allows the user to run funcheck even if the features aren't activated by default.

Copy link
Owner

@froz42 froz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging it !

@froz42 froz42 merged commit 820f6b6 into froz42:main Nov 18, 2024
2 checks passed
@Maix0
Copy link
Contributor Author

Maix0 commented Nov 18, 2024

Hey, I just check and the way I got the git commit doesn't work when using funcheck as an external program. I pushed a commit that fixes that and uses an hardcoded version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants