Added method to handle remote key events to show controls on any keypress #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event. Added method to handle remote key events to show controls on any key event. Now is able to work properly in TV platform showing the controls and hiding again after 5 sec.
frontyard
requested changes
Apr 5, 2017
| @@ -92,6 +92,10 @@ public void onDismiss(DialogInterface dialog) { | |||
| public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) { | |||
| JSONObject payload = Payload.keyEvent(event); | |||
| new CallbackResponse(Player.this.callbackContext).send(PluginResult.Status.OK, payload, true); | |||
|
|
|||
| //Added method to handle remote key events to show controls on any key event | |||
| exoView.showController(); | |||
There was a problem hiding this comment.
This will only show ExoPlayer's controller on the bottom. We also have to support info header on the top which needs to be synchronized with the bottom controlller.
Can you take a look at onTouchListener and see if you can make it work in similar fashion?
There was a problem hiding this comment.
For the moment we are not using the info header, I was trying to implement the same method used in onTouchListener with no results. I'll come back to it when we need to use info header or when I find some time.
There was a problem hiding this comment.
I added after exoView.showController();
show();
show info header on key events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to handle remote key events to show controls on any key event. Now is able to work properly in TV platform showing the controls and hiding again after 5 sec.