Use fully qualified #[test] attribute path #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that uses of
#[test_case]
fail to build when a different procedural macro attribute is imported with the nametest
. For example, the simple test code:results in the build error:
I don't expect
test_case
to necessarily wrap another test helper, but this import probably shouldn't break it. I looked at a couple of other test attributes (#[test_log::test]
and#[tokio::test]
) to confirm they use#[::core::prelude::v1::test]
instead of#[test]
in their generated code to avoid ambiguity, so I think the same approach should probably be applied to#[test_case]
.