✨ Filter bookmark commit out #54
Conversation
| expect(changes).toHaveLength(1) | ||
| expect(changes[0].groups).toHaveLength(1) | ||
| expect(changes[0].groups[0].commits).toHaveLength(1) | ||
| expect(changes[0].groups[0].commits[0]).toEqual(lipstickCommit) |
There was a problem hiding this comment.
The last expect need the previous ones to be true so you can delete them, no ?
There was a problem hiding this comment.
Yeah maybe.
When I wrote those I was more about: "if jest tells me lines where expect is false, I could tell where there is a problem in the code"
And I thank it was better than a JS error.
What do you think?
There was a problem hiding this comment.
I guess i would write 4 different test for this purpose. Ping @Taranys
There was a problem hiding this comment.
Jest produces codeframes so you get a diff between what's expected and what you got.
Then you'll know exactly what is wrong in changes.
There was a problem hiding this comment.
expect(changes).toEqual([{
groups: [{ commits: [lipstickCommit] }],
}])You could also use expect.objectContaining and expect.arrayContaining if you wish to ignore some parts in changes.
There was a problem hiding this comment.
Ok I'll try that, thank you @charlyx
fixes #40