✨ Filter bookmark commit out (#54)

frinyvonnick · Oct 29, 2018 · 7858140 · 7858140
1 parent c4ffc59
commit 7858140
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/packages/gitmoji-changelog-core/src/groupMapping.js b/packages/gitmoji-changelog-core/src/groupMapping.js
@@ -6,7 +6,6 @@ module.exports = [
       'sparkles',
       'tada',
       'white_check_mark',
-      'bookmark',
       'construction_worker',
       'chart_with_upwards_trend',
       'heavy_plus_sign',
@@ -75,6 +74,13 @@ module.exports = [
     label: 'Security',
     emojis: ['lock'],
   },
+  {
+    group: 'useless',
+    label: 'Useless',
+    emojis: [
+      'bookmark',
+    ],
+  },
   {
     group: 'misc',
     label: 'Miscellaneous',

diff --git a/packages/gitmoji-changelog-core/src/index.js b/packages/gitmoji-changelog-core/src/index.js
@@ -57,8 +57,13 @@ function sanitizeVersion(version) {
   })
 }
 
+function filterCommits(commits) {
+  return commits
+    .filter(commit => commit.group !== 'useless')
+}
+
 async function generateVersion({ from, to, version }) {
-  const commits = await getCommits(from, to)
+  const commits = filterCommits(await getCommits(from, to))
   const lastCommitDate = getLastCommitDate(commits)
 
   return {

diff --git a/packages/gitmoji-changelog-core/src/index.spec.js b/packages/gitmoji-changelog-core/src/index.spec.js
@@ -4,6 +4,17 @@ const gitSemverTags = require('git-semver-tags')
 
 const { generateChangelog } = require('./index')
 
+const uselessCommit = {
+  hash: '460b79497ae7e791bc8ba8475bda8f0b93630dd3',
+  date: '2018-09-14T21:00:18+02:00',
+  subject: ':bookmark: Bump version to 1.9.2',
+  body: 'Yes!',
+  emoji: '🔖',
+  emojiCode: 'bookmark',
+  group: 'useless',
+  message: 'Bump version to 1.9.2',
+}
+
 const sparklesCommit = {
   hash: 'c40ee8669ba7ea5151adc2942fa8a7fc98d9e23a',
   date: '2018-08-28T10:06:00+02:00',
@@ -113,6 +124,25 @@ describe('changelog', () => {
     ])
   })
 
+  it('should filter some commits out', async () => {
+    gitRawCommits.mockReset()
+    mockGroup([uselessCommit, lipstickCommit])
+
+    gitSemverTags.mockImplementation(cb => cb(null, []))
+
+    const { changes } = await generateChangelog({ mode: 'init' })
+
+    expect(changes).toEqual([
+      expect.objectContaining({
+        groups: [
+          expect.objectContaining({
+            commits: [lipstickCommit],
+          }),
+        ],
+      }),
+    ])
+  })
+
   it('should throw an error if no commits', async () => {
     mockNoCommits()