Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Rebased on goodtables-ui #274

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Rebased on goodtables-ui #274

merged 1 commit into from
Oct 6, 2017

Conversation

roll
Copy link
Member

@roll roll commented Oct 5, 2017

Here we're rebasing on goodtableUI.Report component. So after this PR goodtables-ui library will be the only source of the Report component for:

  • goodtables.io
  • os-package
  • ckan-integration
  • etc

@roll roll requested a review from amercader October 5, 2017 10:56
@roll
Copy link
Member Author

roll commented Oct 5, 2017

@amercader
Please review

amercader
amercader approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@amercader amercader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Has the interface changed? or is it just the same packaged on goodtables-ui?

@roll
Copy link
Member Author

roll commented Oct 6, 2017

@amercader
I did my best to reverse-engineer gt.io styles into goodtables-ui package - frictionlessdata/goodtables-ui#1 (comment) (here is examples). But if you'll be able to test this PR a little bit it will be great. Or we could test on staging if you merge.

@amercader amercader merged commit f12dfdb into master Oct 6, 2017
@amercader
Copy link
Member

Let's do staging and fix issues, as this is something we need to do for sure

@roll roll deleted the goodtables-ui branch October 6, 2017 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amercader amercader amercader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rebase on [email protected]+ and goodtables-ui
2 participants
@roll @amercader