Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Start repo validation on activation #236

Merged
merged 2 commits into from
May 30, 2017
Merged

Conversation

roll
Copy link
Member

@roll roll commented May 30, 2017


For my piloting and fixing goodtables.io bugs work I've found almost blocking situation that you need to modify repository to get validation results (sometimes it's just not possible).

So for now I've added a trigger to start first validation on default branch straight after repo activation (also we could deactivate/activate repo to trigger validation at any time for any repo - priceless for testing).

It was a trivial change. Let's discuss later in #210 should we keep it or not. But I think for our non-technical users having immediate feedback from the system is essential. We just should add a note about it to Manage Sources page.

@roll roll merged commit 9fc27da into master May 30, 2017
@roll roll deleted the start-repo-validation-on-activation branch May 30, 2017 13:17
@roll roll requested a review from amercader June 12, 2017 07:55
Copy link
Member

@amercader amercader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we definitely need a message that tells users that a job was triggered (here?). We should create an issue for that, which should be easy to implement.

@roll
Copy link
Member Author

roll commented Jun 13, 2017

@amercader
I think we could cover it in more general e.g. here #213 adding help notes to different pages and something like how the service works link in header. For now both triggering on activation or triggering on push are not documented anywhere for new user. So both could be a surprise (or could not).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants