Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322, adds a signal during videobox initialization to adjust video framerate from scene framerate. Gets applied on asset import (drag and drop/ import menu) and on project load so we might want to bump up the project version, since along changing the video framerate to match the scene framerate it also adjusts the video length, which might be a breaking change (then again we were handling it incorrectly before so I don't think it should be allowed if possible, you let me know).
Problems // Limitations
The first and third problems seem easy enough to fix but the second one is kind of major and might need some general tweaking of the way the editor handles scenes and assets, so I'm not entirely sure how to approach it. Maybe it's not a big enough problem to look into it because we realistically don't know how much people would be working on scenes with different framerates in the same project but I still think it's important.
I'd appreciate any help to get this to a better state... (For some reason I'm unable to debug the project, that's why changes on my end take a while).
Here's some example videos I made (on friction) to better test the framerate changes, they sync on this branch but do not on the original.
30fpsanim.mp4
60fpsanim.mp4
600fpsanim.mp4