Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framerate fixes #350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KirbysDarkNebula
Copy link

Fixes #322, adds a signal during videobox initialization to adjust video framerate from scene framerate. Gets applied on asset import (drag and drop/ import menu) and on project load so we might want to bump up the project version, since along changing the video framerate to match the scene framerate it also adjusts the video length, which might be a breaking change (then again we were handling it incorrectly before so I don't think it should be allowed if possible, you let me know).

Problems // Limitations

  • Changing scene framerate doesn't change the framerate of the videos immediately, you'd have to reopen the project after saving (reloading the media doesn't fix it).
  • What I think is a bigger issue is the fact that videos only ever adjust to one framerate, that is, you can have multiple scenes in one project, but the videos will only adjust to the scene they're loaded into, which means the issue we had before persists or gets worse when we change to a scene with different framerate.
  • This does not fix the issue for image sequences, but I can look into it.

The first and third problems seem easy enough to fix but the second one is kind of major and might need some general tweaking of the way the editor handles scenes and assets, so I'm not entirely sure how to approach it. Maybe it's not a big enough problem to look into it because we realistically don't know how much people would be working on scenes with different framerates in the same project but I still think it's important.

I'd appreciate any help to get this to a better state... (For some reason I'm unable to debug the project, that's why changes on my end take a while).

Here's some example videos I made (on friction) to better test the framerate changes, they sync on this branch but do not on the original.

30fpsanim.mp4
60fpsanim.mp4
600fpsanim.mp4

@rodlie
Copy link
Member

rodlie commented Nov 29, 2024

Thanks for working on this, will take a look at the PR and the limitations/issues tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with video speed being affected by scene framerate
2 participants