Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio cmdlet improvement #70

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

@frgnca
Copy link
Owner

frgnca commented Jan 28, 2023

I have never been much of a maintainer so please bear with me. I will test this and try to look at the code more closely, but at first glance this looks like an interesting enhancement.

@StartAutomating
Copy link
Author

@frgnca Thanks!

If you want help maintaining the thing, I'm pretty sure I could step up to the plate.

@frgnca frgnca changed the base branch from master to dev February 19, 2023 15:38
@frgnca
Copy link
Owner

frgnca commented Feb 19, 2023

Would it be possible to prevent Tab autocomplete suggestions such as these?
Write-AudioDevice -PlaybackMeter -RecordingCommunicationMeter
Write-AudioDevice -PlaybackStream -RecordingCommunicationStream
Meaning parameter combinations that results in alternating meters or interwoven streams

@StartAutomating
Copy link
Author

I don't think I've ever figured out a way to make tab completion handle mutually exclusive parameters in the way you're wanting.

I also do recall it was possible to have both a playback meter and a recording meter active.

Personally, I'd consider that a totally valid scenario (think monitoring both your playback and recording levels).

When we're returning data, we could add a noteproperty indicating which stream it is coming from.

We could also get a notch more sophisticated with the return for a stream and return an object of our own design.

This may be preferred, as it gives us a way to provide some analysis of the audio.

For example, we could add a .Phase property (the ratio between two channels of audio)

Lemme know if you'd like me to add more / what you'd like me to add.

I'd very much like this to be updated on the PowerShell Gallery by mid-march, in preparations for some April releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants