Skip to content

Commit

Permalink
Add a dummy workflow to succeed DCO check on merge queues (#366)
Browse files Browse the repository at this point in the history
See #363 for
more details.
  • Loading branch information
llucax authored Apr 28, 2023
2 parents ebeef67 + ee2ac09 commit d3528e9
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,16 @@ jobs:
path: dist/
if-no-files-found: error

generate-docs-pr:
if: github.event_name == 'pull_request'
test-generate-docs:
# This could be github.event_name != 'push', but that's not being triggered
# for merge_group for some reason
if: github.event_name == 'pull_request' || github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-20.04
steps:
- name: DEBUG INFO
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
run: echo $GITHUB_EVENT_NAME
- name: Fetch sources
uses: actions/checkout@v3

Expand All @@ -89,7 +95,7 @@ jobs:
- name: Generate the documentation
env:
MIKE_VERSION: pr-${{ github.event.number }}
MIKE_VERSION: gh-${{ github.job }}
run: |
mike deploy $MIKE_VERSION
mike set-default $MIKE_VERSION
Expand All @@ -103,7 +109,8 @@ jobs:

publish-docs:
needs: ["test", "build-dist"]
if: github.event_name == 'push'
# We shouldn't need the reference name here, but `merge_group` is being executed as if it was `push`
if: github.event_name == 'push' && (github.ref == 'refs/heads/v0.x.x' || startsWith(github.ref, 'refs/tags/'))
runs-on: ubuntu-20.04
permissions:
contents: write
Expand Down Expand Up @@ -180,7 +187,7 @@ jobs:
create-github-release:
needs: ["publish-docs"]
# Create a release only on tags creation
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')
permissions:
# We need write permissions on contents to create GitHub releases and on
# discussions to create the release announcement in the discussion forums
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/dco-merge-queue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Based on https://github.com/hyperledger/besu/pull/5207/files
name: DCO
on:
merge_group:

jobs:
DCO:
runs-on: ubuntu-latest
if: ${{ github.actor != 'dependabot[bot]' }}
steps:
- run: echo "This DCO job runs on merge_queue event and doesn't check PR contents"

0 comments on commit d3528e9

Please sign in to comment.