Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support request option for bounds #20

Closed
cwasicki opened this issue Mar 21, 2024 · 0 comments · Fixed by #98
Closed

Support request option for bounds #20

cwasicki opened this issue Mar 21, 2024 · 0 comments · Fixed by #98
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Milestone
v1.0.0

Comments

@cwasicki
Copy link
Contributor

cwasicki commented Mar 21, 2024 •
edited
Loading

What's needed?

The include option for bounds should be exposed, bound data should be converted from the response and integrated with the output data structure.

Proposed solution

No response

Use cases

No response

Alternatives and workarounds

Additional context

For output data type see also requirements from: #25.
@cwasicki cwasicki added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Mar 21, 2024
@cwasicki cwasicki mentioned this issue Mar 21, 2024
Merged
@cwasicki cwasicki changed the title Support request option for states and bounds Support request option for bounds Mar 21, 2024
@cwasicki cwasicki mentioned this issue Mar 21, 2024
Closed
@flora-hofmann-frequenz flora-hofmann-frequenz added this to the v0.3.0 milestone May 8, 2024
@cwasicki cwasicki modified the milestones: v0.3.0, v0.4.0 May 14, 2024
@cwasicki cwasicki removed this from the v0.4.0 milestone Jun 5, 2024
@cwasicki cwasicki mentioned this issue Jul 15, 2024
Open
@cwasicki cwasicki added this to the v1.0.0 milestone Jul 15, 2024
@cwasicki cwasicki mentioned this issue Sep 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2024
@cwasicki
Add support for bounds in client (#98)
63cd246 
Bounds can now be requested via the client and are provided through the
flat iterator. They can be identified via their category
`metric_bound[i]_{upper,lower}`. Each individual bound is provided as
its own sample.

Support for states and bound is also added to the CLI tool via the
`--bounds` flag.

Fixes
#20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add support for bounds in client cwasicki/frequenz-client-reporting-python
2 participants
@flora-hofmann-frequenz @cwasicki