chore(upgrade): polkadot v1.10 to v1.2.0 #1982

enddynayn · 2024-05-22T22:10:41Z

Goal

Update polkadot from v1.1.0 to v1.2.0.

Polkadot release notes

Lazy Migration
paritytech/polkadot-sdk#1363

Closes #1718

codecov · 2024-05-23T01:08:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

runtime/common/src/weights/pallet_preimage.rs

wilwade · 2024-05-24T13:25:36Z

runtime/frequency/src/lib.rs

@@ -646,7 +649,7 @@ impl pallet_balances::Config for Runtime {
 	type WeightInfo = weights::pallet_balances::SubstrateWeight<Runtime>;
 	type MaxReserves = BalancesMaxReserves;
 	type ReserveIdentifier = [u8; 8];
-	type MaxHolds = ConstU32<0>;
+	type MaxHolds = ConstU32<1>;


Curious why this change. I thought we didn't want to allow holds as they are going away

Although perhaps it is needed to not break the preimage pallet while upgrading?

Great question. I also had to review this part. The introduction of MaxHolds is part of the process of deprecating the Currency trait. To clarify, a hold is similar to the deprecated reserve idea, reducing the free balance in your account. Previously, holds were set to zero because no pallet was utilizing them. However, with the Preimage pallet now using holds, as a result, we increased the MaxHold by one. You can see how holds are utilized in the new associated type called Consideration:

impl pallet_preimage::Config for Runtime { ... type Consideration = HoldConsideration< AccountId, Balances, PreimageHoldReason, LinearStoragePrice<PreimageBaseDeposit, PreimageByteDeposit, Balance>, >; }

This type incorporates the balances pallet, which implements the MutateHold trait. Within the Preimage pallet, the method T::Consideration::new(...) is called, invoking the balances pallet to create a hold.

wilwade

One question about holds, but otherwise looks like a nice simple upgrade.

Read through the changes

Upgrade Polkadot v1.1.0 to v1.2.0. [Polkadot release notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451) Lazy Migration paritytech/polkadot-sdk#1363 Update weights. issue-1718

claireolmstead · 2024-05-28T21:30:54Z

runtime/common/src/weights/pallet_collator_selection.rs

-		// Minimum execution time: 13_175_000 picoseconds.
-		Weight::from_parts(11_629_620, 2809)
-			// Standard Error: 9_686
-			.saturating_add(Weight::from_parts(3_219_955, 0).saturating_mul(b.into()))
+		// Minimum execution time: 13_026_000 picoseconds.
+		Weight::from_parts(11_528_896, 2809)
+			// Standard Error: 11_636
+			.saturating_add(Weight::from_parts(3_232_614, 0).saturating_mul(b.into()))


How do you know what numbers to change all of these values to? They all seem somewhat arbitrary.

These numbers are automatically generated when we run benchmarks against the extrinsics we create. For example, this benchmark tests the performance of the messages pallet. When the benchmarks are executed, they run the specified code and provide measurements of execution time and resource usage. These metrics help us understand the computational cost of transactions and determine appropriate fees.

shannonwells

I reviewed Cargo.lock to check that the update SHA matches the Polkadot release SHA
I checked that new weights were not significantly change from before - around 2 microseconds except where noted.
I reviewed other code changes - mostly the switch to transferAllowDeath and the note about MaxHolds.

shannonwells · 2024-05-28T21:53:55Z

runtime/common/src/weights/pallet_preimage.rs

-			.saturating_add(Weight::from_parts(2_305, 0).saturating_mul(s.into()))
-			.saturating_add(T::DbWeight::get().reads(1_u64))
-			.saturating_add(T::DbWeight::get().writes(2_u64))
+		// Minimum execution time: 45_175_000 picoseconds.


Noting that preimage pallet weights are a lot higher (10+ microseconds some of them) due to extra reads/writes

mattheworris

Read through the changes
Read through the release notes and release analysis
Executed e2e tests (All passed)

Suggestion: Consider adding https://github.com/ggwpez/substrate-scripts/blob/master/migrate-preimage-lazy.py to our scripts, I have found this helpful for running the scripts in the past.

wilwade

Ship it!

Reviewed changes
Ran locally
Ran e2e tests locally

enddynayn requested a review from wilwade as a code owner May 22, 2024 22:10

enddynayn marked this pull request as draft May 22, 2024 22:11

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from 0353c31 to 3fa64ba Compare May 22, 2024 22:58

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 23, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from c998734 to f4d0615 Compare May 23, 2024 17:43

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 23, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from f4d0615 to 1cbb9de Compare May 23, 2024 17:55

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 23, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from 1cbb9de to 669d90b Compare May 23, 2024 21:01

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 23, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch 3 times, most recently from 4208fe8 to 5c119a3 Compare May 23, 2024 21:37

github-actions bot added the metadata-changed Metadata has changed since the latest full release label May 23, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from c686fce to 7de683c Compare May 23, 2024 23:51

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label May 23, 2024

enddynayn commented May 23, 2024

View reviewed changes

runtime/common/src/weights/pallet_preimage.rs Show resolved Hide resolved

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from 7de683c to 9663fa3 Compare May 23, 2024 23:53

enddynayn marked this pull request as ready for review May 23, 2024 23:55

github-actions bot added the metadata-changed Metadata has changed since the latest full release label May 24, 2024

wilwade reviewed May 24, 2024

View reviewed changes

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from 0a96653 to 074b894 Compare May 28, 2024 16:33

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels May 28, 2024

chore(upgrade): polkadot v1.1.0 to v1.2.0

7b2f70c

Upgrade Polkadot v1.1.0 to v1.2.0. [Polkadot release notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451) Lazy Migration paritytech/polkadot-sdk#1363 Update weights. issue-1718

enddynayn force-pushed the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch from 074b894 to 7b2f70c Compare May 28, 2024 20:42

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels May 28, 2024

claireolmstead reviewed May 28, 2024

View reviewed changes

shannonwells approved these changes May 28, 2024

View reviewed changes

mattheworris approved these changes May 28, 2024

View reviewed changes

enddynayn enabled auto-merge (squash) May 29, 2024 00:05

wilwade approved these changes May 29, 2024

View reviewed changes

enddynayn merged commit 81f29ea into main May 29, 2024
28 checks passed

enddynayn deleted the chore/upgrade-polkadot-v1.1.0-to-polkadot-v1.2.0 branch May 29, 2024 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(upgrade): polkadot v1.10 to v1.2.0 #1982

chore(upgrade): polkadot v1.10 to v1.2.0 #1982

enddynayn commented May 22, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

wilwade May 24, 2024 •

edited

Loading

enddynayn May 24, 2024

wilwade left a comment

claireolmstead May 28, 2024 •

edited

Loading

enddynayn May 28, 2024

shannonwells left a comment

shannonwells May 28, 2024

mattheworris left a comment

wilwade left a comment

chore(upgrade): polkadot v1.10 to v1.2.0 #1982

chore(upgrade): polkadot v1.10 to v1.2.0 #1982

Conversation

enddynayn commented May 22, 2024 • edited Loading

Goal

codecov bot commented May 23, 2024 • edited Loading

Codecov Report

wilwade May 24, 2024 • edited Loading

Choose a reason for hiding this comment

enddynayn May 24, 2024

Choose a reason for hiding this comment

wilwade left a comment

Choose a reason for hiding this comment

claireolmstead May 28, 2024 • edited Loading

Choose a reason for hiding this comment

enddynayn May 28, 2024

Choose a reason for hiding this comment

shannonwells left a comment

Choose a reason for hiding this comment

shannonwells May 28, 2024

Choose a reason for hiding this comment

mattheworris left a comment

Choose a reason for hiding this comment

wilwade left a comment

Choose a reason for hiding this comment

enddynayn commented May 22, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

wilwade May 24, 2024 •

edited

Loading

claireolmstead May 28, 2024 •

edited

Loading