Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Ethereum eip-191 signatures are not working correctly #2247

Closed
aramikm opened this issue Jan 3, 2025 · 0 comments · Fixed by #2248
Closed

[Bug]: Ethereum eip-191 signatures are not working correctly #2247

aramikm opened this issue Jan 3, 2025 · 0 comments · Fixed by #2248
Assignees
@aramikm
Labels
bug Something isn't working

Comments

@aramikm
Copy link
Collaborator

aramikm commented Jan 3, 2025 •
edited
Loading

What happened?

Valid ecdsa signatures signed using eip-191 and JS libraries is not getting verified correctly. The issue seems to be related to how the message hash is getting calculated.

Relevant log output

No response
@aramikm aramikm added the bug Something isn't working label Jan 3, 2025
@aramikm aramikm self-assigned this Jan 3, 2025
@aramikm aramikm mentioned this issue Jan 3, 2025
Merged
2 tasks
aramikm added a commit that referenced this issue Jan 3, 2025
@aramikm
bugfix: eip-191 hash calculation fix (#2248)
8945c5e 
# Goal
The goal of this PR is to make sure the hash calculation for eip-191 is
compatible with JS libraries.

Closes #2247 

# Discussion
- Changed eip-191 message hash calculation to match js implementation in
popular Ethereum libraries

# Checklist
- [X] Unit Tests added?
- [X] Spec version incremented?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aramikm aramikm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: eip-191 hash calculation fix frequency-chain/frequency
1 participant
@aramikm