Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support readonly arrays in fallbacks #168

Closed
wants to merge 1 commit into from
Closed

Support readonly arrays in fallbacks #168

wants to merge 1 commit into from

Conversation

NotWoods
Copy link
Contributor

Fixes #110

Changes fallback to use readonly array and adds a test.

If you like these PRs a hacktoberfest-accepted label would be appreciated :)

@frenic frenic mentioned this pull request Apr 1, 2023
Merged
@frenic
Copy link
Owner

frenic commented Apr 1, 2023

I appreciate all PRs even though I find it hard to take my time to go though them at some periods. But this PR modifies index.d.ts directly so I did a PR based on this where that's fixed. Feel free to review it if you'd like. Thanks for your effort 🙏

@frenic frenic closed this Apr 1, 2023
@NotWoods NotWoods deleted the fallback-readonly branch April 2, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark fallback arrays as immutable
2 participants
@NotWoods @frenic