Add broker listen config to wgkex.yaml #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have troubles running the broker from the current main image, since we need the broker to listen on 0.0.0.0 in the Docker container to expose the port.
This is currently not configurable, and setting
FLASK_RUN_HOSTin the Dockerfile or docker-compose.yml doesn't work either, probably because we don't useflask runto start the server.Changes
A new optional section
broker_listenwith the subkeyshostandportis added to wgkex.yaml`.They are passed to Flask if specified, otherwise the Flask defaults are kept.
Tested locally and in an earlier version on docker04.