Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docker-compose #60

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Added docker-compose #60

merged 4 commits into from
Sep 8, 2021

Conversation

lqb
Copy link
Contributor

@lqb lqb commented Sep 7, 2021

  • "docker-compose up -d" should be running without any pre configuration

@awlx
Copy link
Member

awlx commented Sep 8, 2021

I am not a fan of the sed move ... either we provide a wgkex.yaml.docker or something or leave it to manual adjustment.

@awlx awlx requested a review from krombel September 8, 2021 08:27
@lqb
Copy link
Contributor Author

lqb commented Sep 8, 2021

Me either, but better than crushing containers.

@awlx
Copy link
Member

awlx commented Sep 8, 2021

So add a working wgkex.yaml.docker and get rid of the sed

lqb added 2 commits September 8, 2021 22:19
@lqb
Added docker-compose
3fec739 
- "docker-compose up -d" should be running without any pre configuration
@lqb
Added entrypoint
8f185a3
@lqb
Copy link
Contributor Author

lqb commented Sep 8, 2021

No. I just added an entrypoint

@awlx
Copy link
Member

awlx commented Sep 8, 2021

But do hardcoded FFMUC domains make any sense? That's a project for everyone not just us.

@lqb
Copy link
Contributor Author

lqb commented Sep 8, 2021

What do you mean?

@lqb
Copy link
Contributor Author

lqb commented Sep 8, 2021

You can overwrite them with environment variables.

@awlx awlx merged commit d0b382e into main Sep 8, 2021
@awlx awlx deleted the docker-compose branch September 8, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krombel krombel Awaiting requested review from krombel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqb @awlx