Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Use logging instead of print() #55

Merged
merged 2 commits into from
Sep 7, 2021
Merged

- Use logging instead of print() #55

merged 2 commits into from
Sep 7, 2021

Conversation

rucarrol-goog
Copy link
Contributor

  • Force fetch_from_config to raise ValueError on missing keys in config.
  • Fixup tests

@rucarrol-goog
- Use logging instead of print()
0a5edb8 
- Force fetch_from_config to raise ValueError on missing keys in config.
- Fixup tests
awlx
awlx reviewed Sep 7, 2021
View reviewed changes
wgkex/worker/mqtt.py Outdated Show resolved Hide resolved
awlx
awlx approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@awlx awlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Hopefully this helps to find the stall.

@awlx awlx merged commit 8d4d50e into main Sep 7, 2021
@awlx awlx deleted the mqtt_logging branch September 7, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awlx awlx awlx approved these changes

@krombel krombel Awaiting requested review from krombel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rucarrol-goog @awlx