Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select architectural diagram in README based on color scheme #101

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Select architectural diagram in README based on color scheme #101

merged 3 commits into from
Sep 18, 2023

Conversation

penguineer
Copy link
Contributor

The current README is problematic in GitHub dark mode, as the diagram is not legible.

This PR changes the README using the HTML picture element for GitHub to chose the image based on the color scheme.

The dot file generates something else than the existing PNG shows,
so I took the PNG and inverted it. A better solution could be obtained
by matching colors for dark mode.

However, this is still more readable than the current state when in dark mode.
Copy link
Member

@awlx awlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@awlx awlx enabled auto-merge September 18, 2023 11:38
@awlx awlx merged commit 4a9436d into freifunkMUC:main Sep 18, 2023
@penguineer penguineer deleted the dark-mode-readme branch September 18, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants