Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for hardcoded ffmuc stuff and fix it #62

Closed
lqb opened this issue Sep 8, 2021 · 1 comment · Fixed by #63
Closed

Check for hardcoded ffmuc stuff and fix it #62

lqb opened this issue Sep 8, 2021 · 1 comment · Fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lqb
Copy link
Contributor

lqb commented Sep 8, 2021

Check if there is more hardcoded stuff like

wgkex/wgkex/worker/mqtt.py

Line 75 in d0b382e

domain = re.search(r"/.*ffmuc_(\w+)/", message.topic).group(1)

and fix it
@awlx
Copy link
Member

awlx commented Sep 9, 2021

There is already a config variable for this which can be used @lqb. See the cleanup task. It should be easy.

@awlx awlx added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 10, 2021
awlx added a commit that referenced this issue Sep 10, 2021
@awlx
Tune mqtt and resolve #62
5a647b9
@awlx awlx mentioned this issue Sep 10, 2021
Merged
@awlx awlx closed this as completed in #63 Sep 10, 2021
awlx added a commit that referenced this issue Sep 10, 2021
@awlx
Merge pull request #63 from freifunkMUC/tune_mqtt
01af70a 
Tune mqtt and resolve #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tune mqtt and resolve https://github.com/freifunkMUC/wgkex/issues/62 freifunkMUC/wgkex
2 participants
@lqb @awlx