Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: code higlight for domains folder .gitattributes #437

Merged
merged 1 commit into from
Jun 21, 2024
Merged

github: code higlight for domains folder .gitattributes #437

merged 1 commit into from
Jun 21, 2024

Conversation

T0biii
Copy link
Member

@T0biii T0biii commented Jun 17, 2024 •
edited by GoliathLabs
Loading

add code highlights for *.conf files

@T0biii
Create .gitattributes
0107b30 
add code higlight for *.conf
@T0biii T0biii requested review from maurerle and a team as code owners June 17, 2024 14:27
@T0biii T0biii added backport gluon-v2021.1.x Backport to 4/32 Branch backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch labels Jun 17, 2024
grische
grische approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it would be nice to remove the vim annotations then, to make the files consistent. I don't think anyone is using them anymore?

@T0biii
Copy link
Member Author

T0biii commented Jun 17, 2024

@freifunkMUC/firmware does anyone needs the vim annotations?

@T0biii T0biii changed the title code higlight for domains folder .gitattributes github: code higlight for domains folder .gitattributes Jun 20, 2024
@GoliathLabs GoliathLabs merged commit 266d416 into stable Jun 21, 2024
30 checks passed
@GoliathLabs GoliathLabs deleted the T0biii-patch-1 branch June 21, 2024 20:22
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for legacy:

@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for next:

@T0biii T0biii mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grische grische grische approved these changes

@maurerle maurerle Awaiting requested review from maurerle

Assignees
No one assigned
Labels
backport gluon-v2021.1.x Backport to 4/32 Branch backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T0biii @grische @GoliathLabs