Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp-server: implement captive portal option (RFC8910) #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

herbetom
Copy link
Contributor

Clients observing the URI value "urn:ietf:params:capport:unrestricted" may forego time-consuming forms of captive portal detection.

https://datatracker.ietf.org/doc/html/rfc8910


Another option is to provide an URL to an Captive Portal API (RFC8908). This can be static JSON. In the Freifunk context the venue-info-url is probably the most interesting part. When set Users of Android 11 an up are getting a Notifcation which links to the URL provided via venue-info-url. Also it's visible in the Details of the Wifi. For iOS the Link will also be visible there.

https://developer.android.com/about/versions/11/features/captive-portal?hl=de

Providing an actual Captive Portal API hoewer comes with the drawback of requiring a request to the Captive Portal API until a client knows it isn't restricted. Not worse then the current check most clients will presumably do currently but also not better.

For an example of an Captive Portal API see https://darmstadt.freifunk.net/captive

Clients observing the URI value "urn:ietf:params:capport:unrestricted"
may forego time-consuming forms of captive portal detection.

https://datatracker.ietf.org/doc/html/rfc8910
@herbetom herbetom requested a review from a team as a code owner December 11, 2024 15:11
@DasSkelett
Copy link
Member

Thanks, very interesting. Out of interest, do you have experience with the venue-info-url notifications, how often do they show up? Only at very first connect, or everytime the phone reconnects with the SSID?

But for now I also think the "no captive portal" hint is a good start.

@DasSkelett DasSkelett added the enhancement New feature or request label Dec 20, 2024
@herbetom
Copy link
Contributor Author

For Android my experience is that a notification shows up whenever you're connecting:
Screenshot_20241223-064717

You can click it and open the link, the notification stays. You can swipe it away and it will return once you connect again. In addition in the Wifi Settings there is always a "Website Öffnen" Button:

Toggle to view Picture

Screenshot_20241223-064926

But i've also heard reports for Android that the Notification is only shown once. But not my experience on multiple devices.

For iOS it's less aggresive. I think there is an initial notification the first time you connect but after that it's only shown as a Link in the Settings. But don't have much experience with iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants