-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add output file for ffdon #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right? :D
Not quite sure if it's right. From what i could tell filtering works on a site base and what you've listed seem to me to be domains. |
Looks better. I don't know wheter domains can appear multiple times. But it's probably worth an attempt. |
Co-authored-by: DasSkelett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to push a small commit applying the changes that Black complained about in CI so it is green.
Looks good, I'll try deploying it.
Deployed, but the JSON is empty: {"timestamp":"2024-02-11T15:07:29+0100","nodes":[],"links":[]} So maybe the same domain in multiple sites does indeed not work. I might check the yanic code later to confirm this (or see whether it could be changed) |
Turns out yanic uses the Mabye we can adjust |
maybe we can set the Paramter to use the Domaincode instead? https://github.com/FreifunkBremen/yanic/blob/c19c1aed1b237480895e50f0bd50e6ff3758fadd/output/filter/domainassite/domainassite.go#L36
|
according to:
https://gist.github.com/herbetom/f8eae6fde7a00c59f4333b49c189c784
we can add more outputs + filter the output
config is untested