[TASK] Migrate to Vite #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
weeman1337
force-pushed
the
weeman1337/build
branch
from
9fb6d83 to
d9a0687
Compare
Signed-off-by: weeman <[email protected]>
Signed-off-by: weeman <[email protected]>
Add ESLint to scripts. Make polyfill ESLint compliant. Signed-off-by: weeman <[email protected]>
weeman1337
force-pushed
the
weeman1337/build
branch
3 times, most recently
from
ae7f076 to
820793f
Compare
weeman1337
force-pushed
the
weeman1337/build
branch
from
820793f to
175c44c
Compare
MyIgel
requested changes
Oct 4, 2023
There was a problem hiding this comment.
That setup works so great! 😍
Some preliminary findings:
-
npm install shows warnings, can they easily be fixed?
npm WARN deprecated @stylelint/[email protected]: Use the original unforked package instead: postcss-markdown npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser npm WARN deprecated @stylelint/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. npm WARN deprecated [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates. -
There seem to be some possible moderate vulnerabilities, are they easily fixable?
-
When opening a node the left side panel is blank and the console shows an error.
-
When opening the node graph, the page seems to work but shows an error in the console
either way it might have been easier to recview if the linting vs migration would have been two MRs ;)
MyIgel
reviewed
Oct 4, 2023
See https://github.com/sasstools/sass-lint Signed-off-by: weeman <[email protected]>
weeman1337
force-pushed
the
weeman1337/build
branch
from
175c44c to
00b907e
Compare
Closed
Signed-off-by: weeman <[email protected]>
weeman1337
force-pushed
the
weeman1337/build
branch
from
00b907e to
b113ad7
Compare
This was referenced Oct 5, 2023
Closed
MyIgel
requested changes
Oct 5, 2023
MyIgel
approved these changes
Oct 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
MyIgel
requested changes
Oct 6, 2023
MyIgel
reviewed
Oct 6, 2023
weeman1337
force-pushed
the
weeman1337/build
branch
from
b113ad7 to
8e06242
Compare
weeman1337
force-pushed
the
weeman1337/build
branch
from
8e06242 to
2417eea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Danke @weeman1337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
Description + Motivation and Context
This PR migrates the build system from Gulp to Vite. Gulp is rarely maintained, the packages become outdated and it becomes more and more problematic to keep the dependencies up to date. Good example are the overrides to „fix“ the dependencies security issues.
Because this PR touches every file anyway 🤷 It also introduces Prettier for a consistent code-style.
How Has This Been Tested?
Tested builds locally.
Screenshots/links:
No user-facing change
Checklist: