Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docker builds #108

Merged
merged 2 commits into from
Jan 4, 2025
Merged

feat: Docker builds #108

merged 2 commits into from
Jan 4, 2025

Conversation

GoliathLabs
Copy link
Contributor

Description

Adds docker support & proper workflows to automatically build the image.

Motivation and Context

More and more communities are using Docker in their deployments. This makes it possible to package meshviewer as a docker image.

How Has This Been Tested?

In the dev environment over at https://github.com/freifunkMUC/meshviewer

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • [n/a] My change requires a change to the documentation.
    • [n/a] I have updated the documentation accordingly.

@GoliathLabs
Copy link
Contributor Author

After #110 has been merged, this can be rebased and merged as well :)

@ronnyhartenstein
Copy link

ronnyhartenstein commented Oct 7, 2024

Will this PR ever merged? We'd like to use it for Freifunk Chemnitz and don't want to fork it.
Can we contribute something?
/CC @oliverlorenz

@skorpy2009
Copy link
Member

@GoliathLabs can you please update this PR?

@GoliathLabs
Copy link
Contributor Author

@skorpy2009 done :)

@skorpy2009 skorpy2009 merged commit 5d70b72 into freifunk:main Jan 4, 2025
1 check passed
@skorpy2009
Copy link
Member

That didn't work out well.


Check failure on line 24 in .github/workflows/build-docker.yml
GitHub Actions / Build Docker image

Invalid workflow file

The workflow is not valid. .github/workflows/build-docker.yml (Line: 24, Col: 14): Unexpected value ''


@GoliathLabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants