-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gluon-status-page: add channels to status-page #2201
gluon-status-page: add channels to status-page #2201
Conversation
This device is testing this until the PR gets merged: http://lilienstra-e.n.ffh.zone and in case rdns does not work: |
Thanks for working on this. I don't think this feels right next to the client count. How about adding a new "Radio" section and iterate over all radios in there. Maybe also make "channel" part of the key, not the value, and if you are highly motivated maybe also add the frequency in MHz. |
Adding such a section appears to become tricky with the current data.
These two are neither named nor in order of radio0 and radio1. Likely they come out of a lua map and are not ordered at all; just a wild guess, I haven't looked into that yet. Therefore one thing we could do is this: Radio
If you've got an idea @mweinelt or want it like that, let me know in the next hours and I might even get this done before noon. |
For reference: This is what my draft looked like: And http://lilienstra-e.n.ffh.zone does now present the draft with the dedicated radio-section of @mweinelt. Careful, this PR is not updated yet. |
this "channel-number next to client-count" may look a bit misleading if client-AP disbled for a radio and just enabled for wifimesh. |
@Adorfer I'm not sure if I understood you.
is not going to be in the final PR. I do not know about a separate value |
Uh, if I remember correctly this is the same nodeinfo that we use in respondd, so we would need a proper design for how to modify the format. This makes it somewhat more complicated. Mock-Up of what I think would be a big improvement:
|
6e2b7dd
to
cd3a5c4
Compare
This is what we currently can do:
|
550dcb3
to
a8fa65c
Compare
@mweinelt I implemented the changes according to my last answer; http://lilienstra-e.n.ffh.zone runs a firmware similar to this PR, the difference is the place the js is loaded from in order for me to rewrite the js part faster. I marked in code where one would improve after someone tackles #2204. |
While http://lilienstra-e.n.ffh.zone does still contain master and this PR,
Originally posted by @mweinelt in #2201 (comment) it might not make a difference to mark this as blocked until the latter is merged. Else, this would be ready for review and merge afterwords. |
a8fa65c
to
aaaf02b
Compare
aaaf02b
to
f14707c
Compare
As @blocktrron merged the package earlier, I just rebased this on master and added everything @mweinelt requested earlier. The code compiles and still runs here: |
Sorry to be the party pooper here - The respondd-airtime module is an optional dependency (hence it being in the package repo). I like this idea (and would love to see more wireless stats on the status page). So i would propose to move the airtime module to core Gluon. Any objections against that? |
The "packages" repo is for packages that don't depend on the Gluon core, we don't need to move anything. respondd itself is in that repo as well. What we need to decide on is whether we want to make the respondd-airtime module a hard dependency of the status page, or if the page should just omit the missing information when the module is not available. In my opinion making it optional is the better approach. |
I think the current implementation does suffice; Let me know, if you still need changes? A node without the module but with code is this one: |
Implements wifi-channels on status-page
originally #1727, now part of #1415