Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run on browser start #15

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Don't run on browser start #15

merged 2 commits into from
Jun 23, 2024

Conversation

fregante
Copy link
Owner

@fregante fregante commented Mar 16, 2024

It probably isn't needed after #12, so I'll keep this PR open until I see how PixieBrix behaves

Next:

  • Verify the order of execution: onStartup should fire before onExtensionStart

@fregante
Copy link
Owner Author

  • Verify the order of execution: onStartup should fire before onExtensionStart

Done.

It probably isn't needed after #12, so I'll keep this PR open until I see how PixieBrix behaves

This seems to be correct, it "cannot find any tabs" to inject into on startup, but it doesn't hurt to keep this here in case other browsers don't behave the same, or if this changes.

@fregante fregante merged commit 6322c5c into main Jun 23, 2024
15 checks passed
@fregante fregante deleted the no-startup branch June 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable on browser startup
1 participant